fix(transport-stream): Fix import error when using pkg with node v20 #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
released |
|
Thank you! Could you please re-run the tests so I can check if everything's alright? (I don't see an option to re-run them myself) |
|
It’s failing unfortunately |
nagyszabi
force-pushed
the
fix-pkg-with-node-20#1948
branch
from
c2f12ac
to
e42db3d
Compare
|
I fixed the errors for Node v21. I was checking for stderr to be an empty string but it turns out it's a deprecation warning for punnycode: So I added a regex test which checks exactly the warning above. Anything else will fail the test. For Node 18 on MacOS I assume it's not related to my commit since it fails on another test, which works in Linux and Windows. But please run the tests again, and if there is a problem on MacOS I'll look deeper into it. Thank you! |
drazisil
added a commit
to rustymotors/server
that referenced
this pull request
Jun 3, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`^8.18.0` -> `^9.0.0`](https://renovatebot.com/diffs/npm/pino/8.21.0/9.1.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v9.1.0`](https://togithub.com/pinojs/pino/releases/tag/v9.1.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v9.0.0...v9.1.0) #### What's Changed - fix(transport-stream): Fix import error when using pkg with node v20 by [@​nagyszabi](https://togithub.com/nagyszabi) in [pinojs/pino#1949 - Update LTS doc by [@​jsumners](https://togithub.com/jsumners) in [pinojs/pino#1955 - Update pino types for browser.formatters by [@​KatelynKim](https://togithub.com/KatelynKim) in [pinojs/pino#1946 - add node v22 to CI by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1953 - Add Platformatic to sponsors by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1956 - Update h3 example by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1968 - Support file URLs when configuring multiple transports by [@​haines](https://togithub.com/haines) in [pinojs/pino#1961 - Adding support for mix\&match pipelines by [@​dbacarel](https://togithub.com/dbacarel) in [pinojs/pino#1954 - apply serializers to args once before asObject or transmit by [@​emmyakin](https://togithub.com/emmyakin) in [pinojs/pino#1971 - build(deps-dev): bump pino-pretty from 10.3.1 to 11.0.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1933 - build(deps): bump sonic-boom from 3.8.1 to 4.0.1 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1960 - build(deps): bump pino-std-serializers from 6.2.2 to 7.0.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1957 - build(deps-dev): bump tsd from 0.30.7 to 0.31.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1937 - build(deps): bump actions/dependency-review-action from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1894 - build(deps): bump pnpm/action-setup from 2.4.0 to 3.0.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1913 - Drop yarn support and update pnpm by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1972 - build(deps): bump thread-stream from 2.7.0 to 3.0.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1959 #### New Contributors - [@​nagyszabi](https://togithub.com/nagyszabi) made their first contribution in [pinojs/pino#1949 - [@​haines](https://togithub.com/haines) made their first contribution in [pinojs/pino#1961 - [@​emmyakin](https://togithub.com/emmyakin) made their first contribution in [pinojs/pino#1971 **Full Changelog**: pinojs/pino@v9.0.0...v9.1.0 ### [`v9.0.0`](https://togithub.com/pinojs/pino/compare/v8.21.0...4f8ea32aa69ec94b2fb5561716a7701aec991ce7) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.21.0...v9.0.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/rustymotors/server). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1948
Note:
Because the changes to
thread-streamaren't published yet, tests will fail.I tested the code locally, where I manually changed the
thread-streampackage in order to be able to test the changes.